-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen peer dependency on openai #85
Conversation
Currently, package.json specifies a `peerDependency` for the `openai` library at exactly version `4.47.1`. This PR loosens the dependency to any version of the library backward-compatible with 4.47.1. The `openai-node` repo describes their SemVer policy here: https://github.com/openai/openai-node?tab=readme-ov-file#semantic-versioning
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 60a54f4 in 8 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. public-packages/llm-client/package.json:55
- Draft comment:
Loosening theopenai
peer dependency to^4.47.1
is appropriate. This allows for backward-compatible updates, aligning with the SemVer policy of theopenai
library. - Reason this comment was not posted:
Confidence changes required:0%
The change to the peer dependency versioning is appropriate and aligns with the intent of the PR author. The use of the caret (^) allows for backward-compatible updates, which is consistent with the SemVer policy of the openai library.
Workflow ID: wflow_H4WYMehNns4WaOc9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
this is great, thank you! I agree Anthropic should probably be bumped to latest at this point too. I made an update recently that covered a small change in their stream response--will need to test but I think it should be safe. |
🦋 Changeset detectedLatest commit: 7832aeb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for releasing this library! I'm using InstructorJS and interested in comparing some Anthropic and Google models for our use cases.
Changes in this PR
Currently, package.json specifies a
peerDependency
for theopenai
library at exactly version4.47.1
. This PR loosens the dependency to any version of the library backward-compatible with 4.47.1. Theopenai-node
repo describes their SemVer policy here: https://github.com/openai/openai-node?tab=readme-ov-file#semantic-versioningWithout this change you get, for example:
Additional related changes
I figured this was a pretty safe change given SemVer rules. I didn't make any further changes, but here are a few "while I was in there" notes 😄
Since I was looking at the peerDependencies list, I checked that the
@google/generative-ai
one is up-to-date with their latest release ✅The
@anthropic-ai/sdk
peerDependency is specified to^0.22.0
, which is not compatible with their latest SDK. It could be worth bumping and testing that, but I haven't looked into the actual changelog and whether it has meaningful changes.Important
Loosen
openai
peer dependency inpackage.json
to allow backward-compatible versions, resolving npm installation errors.openai
peer dependency inpackage.json
from4.47.1
to^4.47.1
to allow backward-compatible versions.openai
dependency.This description was created by
for 60a54f4. It will automatically update as commits are pushed.